Repository navigation
Release 2.6.6 security hotfix - #119
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe release restricts readable global settings REST access, updates version and changelog metadata to 2.6.6, and changes PHPCS and PHPStan workflows to use PHP 8.3 with revised dependency and autoloader setup. ChangesSettings Access Release
PHP CI Installation
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
danieliser
marked this pull request as ready for review
August 13, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /content-control/v2/settingsto users with the existing settings-administration capabilities.Root cause and impact
The read route used
__return_truebecause it was read-only, but its response contains global plugin settings. That exposed those settings to unauthenticated REST requests. The read route now reuses the same permission callback as the write route, preserving access for users withmanage_optionsoractivate_plugins.Validation
manage_options: allowedactivate_plugins: allowednpm run release:build, completed under the repository's Node 16 runtime.build/artifact contains the protected callback and consistent 2.6.6 plugin/readme metadata.10up/action-wordpress-plugin-deploy@2.3.0, configured repository variables/secrets, and the live plugin SVN history.Release procedure after merge
master.mastercommit and create annotated tagv2.6.6on that commit. Do not tag this PR branch.v2.6.6. The Draft Release workflow builds and attachescontent-control_v2.6.6.zip.build/to SVNtrunkandtags/2.6.6.tags/2.6.6with stable tag 2.6.6.Note: merging to
masteralso triggers the readme/assets workflow. Tag and publish promptly after merge so the new stable-tag metadata is followed immediately by the matching SVN release tag.Summary by CodeRabbit